refactor(YouTube): remove unused code, improve settings (#8901)

* fix: remove nonexistent string

* chore: change default logo option

* fix: remove `adjustTimeError`

* chore: rename Logo option to Image

* perf: run `getTimestampsfromMedia` once

* chore: remove `adjustTimeError`

---------

Signed-off-by: veryCrunchy <me@verycrunchy.dev>

websites/Y/YouTube/metadata.json

@@ -72,7 +72,7 @@
 		"www.youtube.com",
 		"studio.youtube.com"
 	],
-	"version": "5.13.4",
+	"version": "5.13.5",
 	"logo": "https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/logo.png",
 	"thumbnail": "https://cdn.rcd.gg/PreMiD/websites/Y/YouTube/assets/thumbnail.jpg",
 	"color": "#E40813",
@@ -162,9 +162,9 @@
 			"if": {
 				"privacy": false
 			},
-			"title": "Logo",
+			"title": "Image",
 			"icon": "fad fa-images",
-			"value": 0,
+			"value": 1,
 			"values": [
 				"YT Logo",
 				"Thumbnail",

websites/Y/YouTube/presence.ts

@@ -8,7 +8,6 @@ import youtubeMiniplayerResolver from "./video_sources/miniplayer";
 import youtubeApiResolver from "./video_sources/api";
 import {
 	Resolver,
-	adjustTimeError,
 	presence,
 	strings,
 	getSetting,
@@ -145,6 +144,7 @@ presence.on("UpdateData", async () => {
 				unlistedPathElement?.getAttribute("d") ===
 					unlistedBadgeElement?.getAttribute("d"),
 			videoId = resolver.getVideoID(),
+			[startTimestamp, endTimestamp] = presence.getTimestampsfromMedia(video),
 			presenceData: PresenceData = {
 				type: ActivityType.Watching,
 				details: vidDetail
@@ -177,12 +177,8 @@ presence.on("UpdateData", async () => {
 					: isPlaylistLoop
 					? "Playlist on loop"
 					: strings.play,
-				endTimestamp: !video?.paused
-					? adjustTimeError(presence.getTimestampsfromMedia(video)[1], 0.75)
-					: -1,
-				startTimestamp: !video?.paused
-					? adjustTimeError(presence.getTimestampsfromMedia(video)[0], 0.75)
-					: -1,
+				startTimestamp,
+				endTimestamp,
 			};
 
 		if (vidState.includes("{0}")) delete presenceData.state;

websites/Y/YouTube/util/index.ts

@@ -2,12 +2,6 @@ export const presence = new Presence({
 	clientId: "463097721130188830",
 });
 
-let cachedTime = 0;
-export function adjustTimeError(time: number, acceptableError: number): number {
-	if (Math.abs(time - cachedTime) > acceptableError) cachedTime = time;
-	return cachedTime;
-}
-
 export function truncateAfter(str: string, pattern: string): string {
 	return str.slice(0, str.indexOf(pattern));
 }
@@ -69,7 +63,6 @@ const stringMap = {
 	watchStreamButton: "general.buttonWatchStream",
 	watchVideoButton: "general.buttonWatchVideo",
 	viewChannelButton: "general.buttonViewChannel",
-	videos: "youtube.videos",
 	perVideoPrivacyToolTip1: "youtube.perVideoPrivacy.tooltip.1",
 	perVideoPrivacyToolTip2: "youtube.perVideoPrivacy.tooltip.2",
 };