Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for building PreTeXt #19

Open
siefkenj opened this issue Mar 30, 2024 · 7 comments
Open

Github action for building PreTeXt #19

siefkenj opened this issue Mar 30, 2024 · 7 comments

Comments

@siefkenj
Copy link

Not sure where this issue should go, but I have made a github action for building pretext. https://github.com/siefkenj/pretext-build-action When we're comfortable that it works, it should probably move to pretextbook/pretext-build-action.

@StevenClontz @oscarlevin @bjones1 Do ya'll have comments?

@StevenClontz
Copy link
Member

Does this do a pip install -r requirements.txt anywhere? That will ensure that the proper version of pretext-cli is used.

I'd like to use this to get automatic builds for any PR made against github.com/TeamBasedInquiryLearning, at least for the PreTeXt stuff. Would you be available to sync up sometime during PROSE office hours (or otherwise) to help me wire this up? It would be a good field test for this.

@siefkenj
Copy link
Author

No pip install is done, but that should be an easy change. Am I reading correctly that your office hours are 9-11am Eastern on Wednesday?

@StevenClontz
Copy link
Member

Yep.

@siefkenj
Copy link
Author

I could stop by at 11. Would that work?

@StevenClontz
Copy link
Member

Sure - I'll stick around in the https://PROSE.runestone.academy/dropin link after we wrap at 11 eastern to chat with you.

@oscarlevin
Copy link
Member

What do you think about having a examples directory in pretext-cli that contained github actions that people could use/modify if they wanted?

@StevenClontz
Copy link
Member

I think that the majority of authors will want automatic builds and deployments, so I'd strongly support making this part of pretext init/new, with instructions on how to disable them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants