Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Information about prefectConfig is missing in the README for prefect-orion #15

Closed
clamydo opened this issue Jul 29, 2022 · 2 comments · Fixed by #40
Closed

Information about prefectConfig is missing in the README for prefect-orion #15

clamydo opened this issue Jul 29, 2022 · 2 comments · Fixed by #40

Comments

@clamydo
Copy link
Contributor

clamydo commented Jul 29, 2022

Setting prefectConfig is useful to modify prefect's environment variables. However, a documentation, how to use it is missing from the README.

The Chart README seems to be semi-generated. What is a good place to document this?
@jamiezieziula
Copy link
Contributor

Hey @clamydo - I don't see prefectConfig in the orion chart - can you let me know if this issue is still relevant?

@clamydo
Copy link
Contributor Author

clamydo commented Aug 30, 2022 •
edited
Loading

@jamiezieziula, See here

prefect-helm/charts/prefect-orion/templates/_helpers.tpl

Line 169 in 2e665d2

{{- $args := (dict "prefix" "PREFECT_ORION" "map" .Values.prefectConfig) -}} 

{{- $args := (dict "prefix" "PREFECT_ORION" "map" .Values.prefectConfig) -}}

I find this functionality useful for customization.

@jamiezieziula jamiezieziula mentioned this issue Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[orion] Add prefectConfig to values file PrefectHQ/prefect-helm
2 participants
@clamydo @jamiezieziula