Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: remove return_failed kwarg from FlowRunner.run()? #493

Closed
jlowin opened this issue Jan 7, 2019 · 2 comments
Closed

RFC: remove return_failed kwarg from FlowRunner.run()? #493

jlowin opened this issue Jan 7, 2019 · 2 comments

Comments

@jlowin
Copy link
Member

jlowin commented Jan 7, 2019

The more that we run Flows in distributed contexts, and use helpers like raise_on_exception, the less useful I think the return_failed kwarg is for FlowRunner.run(). In particular, it requires some messy code because it can only be satisfied by gathering every single task state to the FlowRunner process, then filtering. If people are finding it useful, then I retract this, but IMO it is not as useful as it used to be.

@jlowin jlowin changed the title RFC: remove returned failed from FlowRunner? RFC: remove return_failed kwarg from FlowRunner.run()? Jan 7, 2019
@jlowin jlowin added RFC labels Jan 7, 2019
@cicdw
Copy link
Member

cicdw commented Jan 7, 2019

I only use raise_on_exception personally, so I'm OK with this

@jlowin
Copy link
Member Author

jlowin commented Jan 7, 2019

I think an improvement would be to create a debug state_handler that added failed tasks to a global dictionary. 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants