Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Use English text by default for missing translations in an already-supported language #59

Open
1 task done
DimitriPilot3 opened this issue Dec 22, 2024 · 0 comments
Labels
awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase

Comments

@DimitriPilot3
Copy link
Contributor

DimitriPilot3 commented Dec 22, 2024

Checked Existing

  • I have checked the repository for duplicate issues.

What enhancement would you like to see?

Currently, the fields of struct config_strings are only implicitly initialized (calling their default constructor). This means if there are any fields that aren't explicitly initialized in the struct returned by get_config_strings, for supported languages (i.e., ones that don't fall back to English), those fields will hold empty strings after the aggregate initialization in get_config_strings.

This could result in messages like the ones added recently (e.g., 686-1001 Module missing added in PR #50) not being seen at all in some languages whose translations are still in progress. Ideally, in such cases the English text should be used instead of an empty string.

empty_item

Any other details to share? (OPTIONAL)

The issue was briefly mentioned in #50 (comment). I figured I should post it here to serve as a reminder before next release.

@DimitriPilot3 DimitriPilot3 added awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-approval Topic has not been approved or denied enhancement An update to an existing part of the codebase
Projects
None yet
Development

No branches or pull requests

1 participant