Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Testing & Dockerization #114

Open
ryand11 opened this issue Aug 22, 2021 · 1 comment
Open

Notification Testing & Dockerization #114

ryand11 opened this issue Aug 22, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@ryand11
Copy link

ryand11 commented Aug 22, 2021

Describe the bug

  1. In Current build, there is no way to test to see if a webhook or SMS is working outside of adding an already in-stock product
  2. After some gymnastics, I was able to dockerize the application with a tweak to your SERVER_URL Parm in index.html. Can this be moved to an .env variable so that this can be hosted on a server? ( I have attached the dockerfile if you'd like to add to your repo)

Logs and Screenshots
No Logs

Platform Information

  • OS: buster aarch64
  • Node version : 13

Screen Shot 2021-08-22 at 11 26 47 AM

@Prince25
Copy link
Owner

Hi there!

Just to make sure I'm understanding this correctly, you're not reporting a bug in the program. You're just suggesting that I:

  1. Add a way to test if webhook or SMS are working.
  2. Make SERVER_ENDPOINT be editable in .env.

If so, then I prefer if you post these suggestions in the discussions so I can track them easier. Number 1 is a good idea and I'll add it to the list of things to do. Number 2, I think it makes more sense to add it to config.json.

@Prince25 Prince25 added the enhancement New feature or request label Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants