Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release the latest package on npm? #85

Closed
ahmadawais opened this issue Sep 24, 2019 · 6 comments
Closed

Release the latest package on npm? #85

ahmadawais opened this issue Sep 24, 2019 · 6 comments

Comments

@ahmadawais
Copy link
Contributor

Users have been asking me to add theme here and I did.

Can you folks release the latest pkg on npm?

https://www.npmjs.com/package/prism-themes

It's outdated.
@RunDevelopment
Copy link
Member

Yeah, that'd be great.
@mAAdhaTTah

But could we get #79 before that? It's just sitting there, all alone, rebased, and ready to merge.

@mAAdhaTTah
Copy link
Member

Approved that. There's also #84 for screenshots, but there's some massaging to be done there.

@RunDevelopment
Copy link
Member

Yes, but #84 is only a readme change, so I don't think that we need to delay the release.

Also, could please also merge #79. I'm not listed as a collaborator for this project, so I can't.

@mAAdhaTTah
Copy link
Member

Done. Will release when I'm home.

The README change might be nice for npm but not a requirement.

@RunDevelopment
Copy link
Member

Nice!

The README change might be nice for npm but not a requirement.

Exactly what I was thinking.

I'll review #84, so we can merge it then.

@mAAdhaTTah
Copy link
Member

Published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ahmadawais @mAAdhaTTah @RunDevelopment