Don't process language if block language not set #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding this guard to the function prevents an error if the language is undefined. `env.language.substring(0, 1).toUpperCase()` can fail with `Uncaught TypeError: Cannot read property 'substring' of undefined` when `env.language` is undefined.
|
This shouldn't go there. Right under it, you can see a conditional that checks a number of other things before it falls back to |
jwworth
added a commit
to hashrocket/tilex
that referenced
this pull request
Apr 27, 2018
|
Great point! I moved the conditional down, and added a check for |
mAAdhaTTah
approved these changes
Apr 28, 2018
|
No, LGTM too. |
jwworth
added a commit
to hashrocket/tilex
that referenced
this pull request
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this guard to the function prevents an error if the language is undefined.
env.language.substring(0, 1).toUpperCase()can fail withUncaught TypeError: Cannot read property 'substring' of undefinedwhenenv.languageis undefined.