Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java stack trace support #1520

Merged
merged 5 commits into from
Dec 2, 2018
Merged

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Aug 8, 2018

Since the original PR for Java stack traces #916 wasn't continued I decided to try it. So, here is my take on it.


This PR adds support for Java stack traces.

There are 3 main types of elements which are highlighted:

  1. The summary.
    This is the head of the stack trace and includes the name of the exception and a message.
    Exception in thread "main" java.lang.RuntimeException: A test exception
  2. Stack frames.
    These make up the actual stack trace and include the full name of the method and the source.
    at com.stackify.stacktrace.StackTraceExample.methodB(StackTraceExample.java:13)
  3. Omitted frames.
    This is a simple message that some frames were omitted.
    ... 27 more

Everything besides these 3 element types will not be highlighted.

Example

image

@RunDevelopment RunDevelopment changed the title Added support for Java stack traces Java stack trace support Aug 8, 2018
@mAAdhaTTah
Copy link
Member

Thanks for this. One quick note: let's leave the package-lock.json out of this PR for now, since we don't have one currently. If we're going to add it, we should do that separately.

@RunDevelopment
Copy link
Member Author

Oops, my bad. I forgot to delete it.

@mAAdhaTTah
Copy link
Member

Tests all look pretty good here, but I'll need @Golmote or @LeaVerou to review the Regex here. Also got a conflict that will need to be resolved.

@mAAdhaTTah
Copy link
Member

If we resolve these conflicts, we can merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants