Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added G-code language #1572

Merged
merged 8 commits into from
Dec 1, 2018
Merged

Added G-code language #1572

merged 8 commits into from
Dec 1, 2018

Conversation

RunDevelopment
Copy link
Member

@RunDevelopment RunDevelopment commented Sep 23, 2018

This PR adds the G-code language to Prism and resolves #1571.

Features

Example

image

@marc-medley
Copy link

@RunDevelopment Any insight (time estimate) regarding when #1572 might actually be merged?

@RunDevelopment
Copy link
Member Author

@marc-medley
Big changes, like adding a new language, require a proper code review, which is typically done by one of the maintains. But Prism's maintains seem to be very busy at the moment and they also have quite a list of PRs to go through.

So, maybe a few weeks?
It's hard to tell.

@mAAdhaTTah
Copy link
Member

This looks good. Just some conflicts to resolve.

@mAAdhaTTah mAAdhaTTah merged commit 2288c25 into PrismJS:master Dec 1, 2018
@RunDevelopment RunDevelopment deleted the g-code branch December 1, 2018 17:40
ggrossetie pushed a commit to ggrossetie/prism that referenced this pull request Mar 11, 2019
This PR adds the [G-code language](https://reprap.org/wiki/G-code) to Prism
and resolves PrismJS#1571.

### Features

- All fields from A-Z ([case sensitive](https://reprap.org/wiki/G-code#Case_sensitivity)) and [checksums](https://reprap.org/wiki/G-code#.2A:_Checksum) (`*`).
- [Comments](https://reprap.org/wiki/G-code#Comments) of both the semicolon and parenthesis style.
- [Quoted strings](https://reprap.org/wiki/G-code#Quoted_strings).
- The colon punctuation of [lists (see the example)](https://reprap.org/wiki/G-code#M584:_Set_drive_mapping).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: gcode highlighting
3 participants