Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build actual releases #165

Closed
apfelbox opened this issue Sep 13, 2013 · 15 comments
Closed

Build actual releases #165

apfelbox opened this issue Sep 13, 2013 · 15 comments

Comments

@apfelbox
Copy link
Contributor

Hi,

since there already are quite a lot of external libraries or tools which build on or include prism, it would be nice, if there were actual releases with release version numbers (preferably semver of course ;-) ).

Tools which build on prism:

  • bower or other package managers (declare dependency by version number)
  • Tools like Prism Detached (which includes prism in wordpress)

etc...

@milesj
Copy link
Contributor

milesj commented Sep 13, 2013

I also feel like the prism source and website should be separated. Throw in some Grunt and build packaging as well.

@apfelbox apfelbox mentioned this issue Oct 3, 2013
@rxaviers
Copy link

rxaviers commented Oct 8, 2013

👍

@LeaVerou
Copy link
Member

LeaVerou commented Oct 8, 2013

I also feel like the prism source and website should be separated. Throw in some Grunt and build packaging as well.

Well, at least they’re in separate folders now :P

@markdalgleish
Copy link

+1

I use Prism in Bespoke.js Generator and moving the themes into a separate folder broke my boilerplate (see this pull request I received to fix it). I'd love to lock in a version of Prism with the generator to avoid these sorts of issues.

I agree that the themes should have been moved, but that should also constitute a version bump IMO.

@franz-josef-kaiser
Copy link

👍

Gruntfile would be nice.

@apfelbox apfelbox mentioned this issue Jun 1, 2014
@CaryLandholt
Copy link

Terrific library. Definitely need tagged releases to be consumable in a predictable way.
Pulling from gh-pages is not sufficient. As mentioned in other issues, bower doesn't like it.

Although the following works, it's not versioned or convenient.

$ bower install git@github.com:LeaVerou/prism.git\#gh-pages

@LeaVerou, terrific job on the library, however.

@Anahkiasen
Copy link

Is there still no plans for tagged releases?

@apfelbox
Copy link
Contributor Author

Currently in work. Please keep patient just a little longer.

@paazmaya
Copy link

+1

@franz-josef-kaiser
Copy link

@apfelbox Is this the repo where you send PRs from?

@apfelbox
Copy link
Contributor Author

@franz-josef-kaiser yep. Although I have to confess that I mainly work on my local machine and just push to my fork as soon as its ready for the PR.

I will try to change that, that one can see the progress of the work.

@franz-josef-kaiser
Copy link

If you'd do micro commits (one minor changed block, one commit) it would be easier to drop or replace certain things later on. It as well would make it possible for someone to jump in. Anyway 👍 for doing that!

@apfelbox
Copy link
Contributor Author

We now have a v1.0 🎈

@franz-josef-kaiser
Copy link

@apfelbox why the v? Semver does not have the v.

(Still a big win as most package manager will recognize that as valid)

@apfelbox
Copy link
Contributor Author

@franz-josef-kaiser I didn't create the tag, I am just the announcer. ;)

I currently prefer it without the "v", but as practically all package manager handle both cases quite well, it is up to the personal taste of the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants