Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vala language #1658

Merged
merged 14 commits into from
Dec 15, 2018
Merged

Add Vala language #1658

merged 14 commits into from
Dec 15, 2018

Conversation

luaVolk
Copy link
Contributor

@luaVolk luaVolk commented Dec 10, 2018

No description provided.

Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

There are however a few problems we have to fix before we can merge this.

  1. Because Vala allows any number of spaces after a function name, you will have to change the function pattern to match things like void main () { ... }.
  2. The number pattern does not include 0.75f.
  3. -> is not matched by puncuation.

I also left you some comments.

components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
components/prism-vala.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

Please re-run gulp and then I will gladly merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants