-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding bottom to toc #1681
Adding bottom to toc #1681
Conversation
This fixed the toc which is otherwise cut off at the bottom in chrome at least.
This approach has the problem that when scrolled to the bottom of the page, the TOC is under the footer. A better (but also more complex) solution would be to move the TOC to the top while scrolling using JavaScript, so that |
This is true, although I think it is still better than having only half of the nav for the entire time. 😉 |
Sorry for not getting back to you! My problem is that the TOC will disappear at the end of the page. On smaller screens, this might not be a problem but for larger ones, the end of the page comes to you quickly. So how about this: We wrap your |
Seems like this can be fixed by setting the TOC's |
Also, what do think about making It's a little awkward to see the TOC move a few pixels as you resize the page. |
Will change it. I prefer |
Okay, changed it.
|
Should all be fixed by now. |
Nice! Could you please restore the green checkmarks to their former size ( And please bring back the hover effect. Changing the color instead of the opacity in |
Done. 👍 |
I forgot one last thing: The FAQ page treats the TOC as part of the content section. The cool hover effect shouldn't be there. |
Updated the faq.html. |
Thank you for contributing! |
Sure, happy to see it fixed. 😉 |
This fixed the toc which is otherwise cut off at the bottom in chrome at least.