Show language improvements #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Jan 22, 2019
|
|
||
| for (var name in data.languages[p].aliasTitles) { | ||
| languagesMap[name] = data.languages[p].aliasTitles[name]; | ||
| addLanguageTitle(name, data.languages[p].aliasTitles[name]); |
There was a problem hiding this comment.
I don't think we just want to run this through addLanguageTitle, as we do want to add the name even if the guessed title doesn't match the title.
There was a problem hiding this comment.
Oh wait, this is the gulpfile, not show-language,
mAAdhaTTah
approved these changes
Jan 22, 2019
|
This also includes a different version of |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug that aliases without a title (e.g.
jsfor JavaScript) were not included in the language map.It also improves the guessing of a language's title by capitalizing 'script' to correctly guess ActionScript, AppleScript, CoffeeScript, JavaScript, LiveScript, and TypeScript.