Npm: Fixed mocha and gulp-uglify vulnerabilities #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't we upgrade to gulp 4 already? |
|
Yes, but only |
|
Can we go straight to mocha@6? |
|
I updated all dependencies now and everything works just fine. I just wonder why the minified files changed again... |
mAAdhaTTah
approved these changes
Mar 6, 2019
Merged
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings mocha (
2.2.5->5.2.0) and gulp-uglify (0.3.1->3.0.1) to the latest versions and fixes 5/11 vulnerabilities.(I only changed
package.json)Almost all minified are different because of the uglify update.
Keep in mind merging this will create conflicts for almost every other PR because of the minified files.
I will upgrade gulp (
3.8.6->4.0.0) once this and #1741 are through becausegulpfile.jshas to be changed.