gulp: Refactoring #1780
Merged
gulp: Refactoring #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mAAdhaTTah
reviewed
Mar 2, 2019
gulpfile.js
Outdated
| function build(cb) { | ||
| pump([src(paths.main), header('\n/* **********************************************\n' + | ||
| ' Begin <%= file.relative %>\n' + | ||
| '********************************************** */\n\n'), concat('prism.js'), dest('./')], cb); |
There was a problem hiding this comment.
If we're ES6-ifying everything, we can make this a template string.
There was a problem hiding this comment.
Suggested change
| '********************************************** */\n\n'), concat('prism.js'), dest('./')], cb); | |
| ********************************************** */ | |
| `), concat('prism.js'), dest('./')], cb); |
There was a problem hiding this comment.
I didn't do this because then the line ends of prism.js depend on the line ends of gulpfile.js.
But if you think that that's not a problem I'll change it.
There was a problem hiding this comment.
nvm. Template strings ftw! I already use them anyway for components.js.
ExE-Boss
reviewed
Mar 2, 2019
gulpfile.js
Outdated
| pump([src(paths.plugins), ...minifyJS(), rename({ suffix: '.min' }), dest('plugins')], cb); | ||
| } | ||
| function build(cb) { | ||
| pump([src(paths.main), header('\n/* **********************************************\n' + |
There was a problem hiding this comment.
Suggested change
| pump([src(paths.main), header('\n/* **********************************************\n' + | |
| pump([src(paths.main), header(` | |
| /* ********************************************** |
gulpfile.js
Outdated
| } | ||
| function build(cb) { | ||
| pump([src(paths.main), header('\n/* **********************************************\n' + | ||
| ' Begin <%= file.relative %>\n' + |
There was a problem hiding this comment.
Suggested change
| ' Begin <%= file.relative %>\n' + | |
| Begin <%= file.relative %> |
gulpfile.js
Outdated
| function build(cb) { | ||
| pump([src(paths.main), header('\n/* **********************************************\n' + | ||
| ' Begin <%= file.relative %>\n' + | ||
| '********************************************** */\n\n'), concat('prism.js'), dest('./')], cb); |
There was a problem hiding this comment.
Suggested change
| '********************************************** */\n\n'), concat('prism.js'), dest('./')], cb); | |
| ********************************************** */ | |
| `), concat('prism.js'), dest('./')], cb); |
This was referenced Oct 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we just switched to gulp v4 (#1779) and dropped support for Node 4 some time ago, I took the chance to refactor our
gulpfile.js.I used ES6 syntax and removed
gulp.taskwhich is not recommended anymore.(Let's see if Node v6 can handle the changes. Edit: It worked.)