Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(gulp): Use async functions #1783

Merged
merged 4 commits into from
Jul 17, 2019
Merged

refactor(gulp): Use async functions #1783

merged 4 commits into from
Jul 17, 2019

Conversation

ExE-Boss
Copy link
Contributor

@ExE-Boss ExE-Boss commented Mar 1, 2019 •
edited
Loading

Depends on #1780 and dropping Node <7.6.0.

@RunDevelopment
Copy link
Member

I was also thinking about using async functions when writing #1780 but didn't because Node v6 isn't dead yet even though it will be very soon.

So I really don't know if we want to drop Node v6 just to have a nicer build process.
I don't think it's worth it.

@RunDevelopment
Copy link
Member

Let's just keep this open for a month or two until Node v6 is dead.

@ExE-Boss You might want to remove Node v6 from .travis.yml to make the build succeed.

@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Mar 2, 2019 •
edited
Loading

In the meantime, you should get #1780 and #1776 merged.

@ExE-Boss ExE-Boss closed this Mar 2, 2019
@ExE-Boss ExE-Boss reopened this Mar 2, 2019
@ExE-Boss
Copy link
Contributor Author

ExE-Boss commented Mar 2, 2019

Travis was acting up, closing and reopening solves it in most cases.

mAAdhaTTah
mAAdhaTTah reviewed Mar 10, 2019
View reviewed changes
gulpfile.js Outdated Show resolved Hide resolved
@RunDevelopment
Copy link
Member

@ExE-Boss
Node v6 is (finally) dead, so we can merge this now after the conflicts are resolved and the last comment is addressed.

@RunDevelopment
Copy link
Member

@ExE-Boss Is this still active?
If you're too busy right now, I'll gladly take over. Just let me know.

Same for #1796.

@RunDevelopment RunDevelopment merged commit 0dd44d5 into PrismJS:master Jul 17, 2019
@ExE-Boss ExE-Boss deleted the gulp/use-async-functions branch July 17, 2019 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah left review comments

@RunDevelopment RunDevelopment RunDevelopment approved these changes

Assignees
No one assigned
Labels
enhancement needs changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ExE-Boss @RunDevelopment @mAAdhaTTah