Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis: Fail if files change after gulp #1785

Closed
RunDevelopment opened this issue Mar 1, 2019 · 0 comments · Fixed by #1819
Closed

Travis: Fail if files change after gulp #1785

RunDevelopment opened this issue Mar 1, 2019 · 0 comments · Fixed by #1819

Comments

@RunDevelopment
Copy link
Member

A lot of times, contributors (myself included) forgot to build or commit the minified files.

Since Travis is running gulp anyway, why not check for changes?
The current gulp build process is deterministic and only depends on the input files, so successive build won't change any files. So if files do change, we know that someone forgot to rebuild Prism.

We should be able to use git status to detect the changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant