Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Refactoring #1795

Merged
merged 2 commits into from
Mar 10, 2019
Merged

Conversation

RunDevelopment
Copy link
Member

I refactored all test related files to use ES6 features.

@mAAdhaTTah
Copy link
Member

My only concern about this is it's a little weird to only allow ES6 in the tests but not in the core of the library. Maybe we can enforce this with ESLint?

@RunDevelopment
Copy link
Member Author

Why is this weird? Everything made exclusively for a node environment is ES6 and the code which is also available for browser is ES5.

Well, we could use Babel to solve this and make everything ES6 or we could wait for #1578.

Maybe we can enforce this with ESLint?

Enforce what?

@mAAdhaTTah
Copy link
Member

I'm pretty sure we can enforce es5 env in the core / languages / plugins area and enable es6 env in the tests with ESLint.

@mAAdhaTTah
Copy link
Member

It's weird mostly cuz, as a developer, I have to remember "I'm in core, I can only use ES5" to "now I'm in tests, I can use ES6+".

@RunDevelopment
Copy link
Member Author

RunDevelopment commented Mar 10, 2019

We enforce ES5 for core / languages / plugins already because Uglify doesn't support ES6.
So it lets you know when you use modern features...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants