Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solidity support revisited revisited #2031

Conversation

RunDevelopment
Copy link
Member

I completely rewrote the Solidity language. It now uses C like as a base because it's less likely to change compared to JS and because JS contains a lot of features which Solidity doesn't.

I also added a few tests.

Example

image


This closes #1843 and resolves #1404.

Copy link
Member

@mAAdhaTTah mAAdhaTTah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question on the test but otherwise lgtm

@RunDevelopment RunDevelopment merged commit cc2cf3f into PrismJS:master Sep 2, 2019
@RunDevelopment RunDevelopment deleted the solidity-support-revisited-revisited branch September 2, 2019 18:29
@cliffhall
Copy link

@davidmurdoch When will you be tagging a version including solidity.min.js and pushing to unpkg.com?

@mAAdhaTTah
Copy link
Member

We have 3 PRs slated for the next release, so whenever those are in, we'll cut the next one.

@cliffhall
Copy link

Cool. I'm just serving a local copy for now. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Solidity?
5 participants