Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single-quote-character not a string, fixes #2039 #2041

Merged

Conversation

bencoman
Copy link
Contributor

@bencoman bencoman commented Sep 4, 2019

For Smalltalk, a single quote character... $'
does not start a string e.g. 'foobar'.
Fixes #2039.

@RunDevelopment
Copy link
Member

Thank you for the fix @bencoman!

Before we can merge this, you have to rebuild Prism (this is also the reason why the build failed). To do this run the npx gulp command. This will automatically minify all languages definitions.

@bencoman bencoman force-pushed the Smalltalk-single-quote-character branch from 4c46f9a to e973a7a Compare September 4, 2019 13:28
@bencoman
Copy link
Contributor Author

bencoman commented Sep 4, 2019

I'm not familiar with this error "cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing."

@RunDevelopment
Copy link
Member

RunDevelopment commented Sep 4, 2019

Unfortunately, neither am I, but I still have a fix.
Please revert your changes to package.json and package-lock.json. Then use npm ci instead of npm install. After that, npx gulp again. This should fix the build and also revert the ~10 other minified files that changed.

I'm sorry about the incorrect instruction from before.

@mAAdhaTTah
Copy link
Member

cipm was the name of the npm ci command before it was merged into npm core. npm ci uses the lockfile only to install the npm dependencies. It's warning you that because the lockfile & the pkg.json out of sync, relying on the lockfile alone won't produce the expected results, so it errors.

That said, @RunDevelopment's solution should work.

@bencoman bencoman force-pushed the Smalltalk-single-quote-character branch from e973a7a to 7023459 Compare September 4, 2019 15:37
@RunDevelopment RunDevelopment merged commit 1aabcd1 into PrismJS:master Sep 4, 2019
@RunDevelopment
Copy link
Member

Thank you for contributing @bencoman!

@bencoman bencoman deleted the Smalltalk-single-quote-character branch September 4, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smalltalk: single-quote-character is not a string
3 participants