Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Adds a check redundant dependency declarations #2142

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Tests: Adds a check redundant dependency declarations #2142

merged 2 commits into from
Jan 5, 2020

Conversation

RunDevelopment
Copy link
Member

Since it's possible to have redundant dependency declarations (e.g. require + optional for the same component), I decided to add a test for it.

@RunDevelopment
Copy link
Member Author

@mAAdhaTTah Should we really merge these before the new release?

@RunDevelopment RunDevelopment merged commit a06aca0 into PrismJS:master Jan 5, 2020
@RunDevelopment RunDevelopment deleted the redundant-deps-check branch January 5, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mAAdhaTTah mAAdhaTTah mAAdhaTTah approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RunDevelopment @mAAdhaTTah