Autoloader: Fixed data-dependencies and extensions #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should also point out that this fixes the bug that blocks #1936. |
mAAdhaTTah
reviewed
Jun 27, 2020
mAAdhaTTah
reviewed
Jun 27, 2020
mAAdhaTTah
reviewed
Jun 27, 2020
mAAdhaTTah
approved these changes
Jun 27, 2020
RunDevelopment
commented
Jun 30, 2020
|
|
||
| if (!deps.every(isLoaded)) { | ||
| // the language or some dependencies aren't loaded | ||
| loadLanguages(dependencies, function () { |
There was a problem hiding this comment.
Guess who meant to write deps and not dependencies? Fixed in #2449.
quentinvernot
pushed a commit
to TankerHQ/prismjs
that referenced
this pull request
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1994. This fixes #1976.
It does so by using a new method to check whether a language is already loaded. It now checks whether the language and
data-dependencieshave been loaded instead of checking whether the current grammar is defined.