Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown: Add support for image #2676

Closed
hdsuperman opened this issue Dec 18, 2020 · 3 comments · Fixed by #2678
Closed

Markdown: Add support for image #2676

hdsuperman opened this issue Dec 18, 2020 · 3 comments · Fixed by #2678
Labels
enhancement

Comments

@hdsuperman
Copy link

Motivation
support image token
Description

![emoji](https://content.markdowner.net/emoji/g/64/1f44d.png)

emoji
@RunDevelopment
Copy link
Member

May I ask what exactly you mean by "support"? We already highlight image links correctly, so what more is there to support for a syntax highlighter?

@hdsuperman
Copy link
Author

extract as image token, so we can get more information from the token (alt, src, title), this can facilitate custom rendering

![emoji](https://content.markdowner.net/emoji/g/64/1f44d.png "This is title")

@RunDevelopment
Copy link
Member

Ok. I'll make a PR.

@RunDevelopment RunDevelopment mentioned this issue Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Markdown: Improved URL tokenization RunDevelopment/prism
2 participants
@RunDevelopment @hdsuperman