Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data-URI Highlight plugin #996

Merged
merged 2 commits into from
Jul 14, 2016
Merged

Conversation

Golmote
Copy link
Contributor

@Golmote Golmote commented Jul 10, 2016

This PR is a proposal for #485. It is inspired by the Autolinker plugin.

f851ed7b73

A small change was made to the Autolinker plugin so that both are compatible.

@zeitgeist87
Copy link
Collaborator

Very nice plugin! It works very well.

Maybe we should remove 'comment' from the candidates array. It is very unlikely that a data-uri is inside a comment and even if there is one it probably shouldn't be highlighted, because it looks a bit weird:

comment

What do you think?

@Golmote
Copy link
Contributor Author

Golmote commented Jul 11, 2016

Haha indeed this is ridiculous! ^^ This is fixed, thanks!

@Golmote Golmote merged commit bdca61b into PrismJS:gh-pages Jul 14, 2016
@Golmote Golmote deleted the data-uri-highlight branch July 14, 2016 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants