Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize doc using chatgpt. #974

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Optimize doc using chatgpt. #974

merged 2 commits into from
Jan 10, 2025

Conversation

rom1504
Copy link
Member

@rom1504 rom1504 commented Jan 10, 2025

Changes

  • pagination
  • lazy rendering by subsets instead of prerendering everything
  • some formatting

Changes
- pagination
- lazy rendering by subsets instead of prerendering everything
- some formatting
@rom1504 rom1504 requested a review from extremeheat January 10, 2025 17:00
@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2025

it goes from 4s to 0.5s rendering

what do you think @extremeheat ?

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2025

looks like
image

which I think is fine

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2025

ah but that breaks search and filtering...

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2025

fixed

@rom1504
Copy link
Member Author

rom1504 commented Jan 10, 2025

canvas feature of chatgpt is interesting, it shows line by line edit
however it's pretty slow

Copy link
Member

@extremeheat extremeheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rom1504 rom1504 merged commit c88c1f8 into web Jan 10, 2025
3 checks passed
@rom1504 rom1504 deleted the optimize_web branch January 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants