Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Documentation for mineflayer.Container refers to bot.openChest(), which is deprecated #2593

Open
creator1creeper1 opened this issue Apr 19, 2022 · 6 comments
Open

Documentation: Documentation for mineflayer.Container refers to bot.openChest(), which is deprecated #2593

creator1creeper1 opened this issue Apr 19, 2022 · 6 comments
Labels
documentation good first issue low priority Ready for implementation Stage3 idea is precisely specified, only coding is left to do

Comments

@creator1creeper1
Copy link

The documentation for mineflayer.Container says: "Extends windows.Window for chests, dispensers, etc... See bot.openChest(chestBlock or minecartchestEntity).". However, the documentation for bot.openChest() says "Deprecated. Same as openContainer". The documentation for mineflayer.Container should probably directly point at bot.openContainer().
@creator1creeper1 creator1creeper1 added possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Apr 19, 2022
@amoraschi
Copy link
Contributor

PRs open

@creator1creeper1
Copy link
Author

I don't wanna clone the repo right now. I'll probably open a PR later though.

@creator1creeper1
Copy link
Author

Also at least the chest.js example still uses bot.openChest(). The examples probably shouldn't use deprecated functions. I'll put that in the PR too when I get around to it.

@u9g
Copy link
Member

u9g commented Apr 19, 2022

Todo:

  • Update docs
  • Update example

@u9g u9g added documentation Ready for implementation Stage3 idea is precisely specified, only coding is left to do good first issue low priority and removed possible bug Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Apr 19, 2022
@slightly-imperfect
Copy link
Contributor

slightly-imperfect commented Jun 11, 2022 •
edited
Loading

Hi, inexperienced programmer here, was looking for good-first-issues tags, so I can get experience with PRs on GitHub.
I've

  • updated docs, in all languages using google translate

  • updated examples

@slightly-imperfect slightly-imperfect mentioned this issue Jun 11, 2022
Merged
3 tasks
@slightly-imperfect
Copy link
Contributor

#2656
I'm slightly unsure how to make a PR. Seem to have accidentally made a different issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue low priority Ready for implementation Stage3 idea is precisely specified, only coding is left to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@u9g @slightly-imperfect @amoraschi @creator1creeper1