Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .isOnLadder() condition #111

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Conversation

szdytom
Copy link
Contributor

@szdytom szdytom commented Nov 1, 2023

The problem: I have noticed the bot cannot climb trapdoors that is directly above ladders (#109). I have also noticed that in 1.20.1 the bot cannot jump to climb ladders (#108).

In this pull request:

  • I've added a new feature climableTrapdoor to indicate whether the trapdoors is climbable. Reference: Trapdoor History - Minecraft Wiki
  • I've added code in function isOnLadder to handdle trapdoors.
  • I've added a few missing versions to features.json

Fixes #108
Fixes #109
Closes #110

@rom1504 rom1504 requested a review from extremeheat December 17, 2023 18:05
@rom1504
Copy link
Member

rom1504 commented Dec 17, 2023

can you take another look @extremeheat ?

Copy link
Member

@extremeheat extremeheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can use block._properties instead of getProperties() (which creates a temporary object), but otherwise good

@szdytom
Copy link
Contributor Author

szdytom commented Jun 7, 2024

would you take another look please, I've updated the code. Thanks

@rom1504 rom1504 merged commit 03b2e44 into PrismarineJS:master Jan 24, 2025
3 checks passed
@rom1504
Copy link
Member

rom1504 commented Jan 24, 2025

/makerelease

@rom1504bot rom1504bot mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Cannot climb trapdoors dirrectly above ladders Feature lists is not updated
4 participants