Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port is passed to function in network byte order #33

Open
undroidwish opened this issue Oct 28, 2023 · 0 comments
Open

port is passed to function in network byte order #33

undroidwish opened this issue Oct 28, 2023 · 0 comments

Comments

@undroidwish
Copy link

On line

mdnsd/libmdnsd/mdnsd.c

Line 743 in 488d24f

if (!hasConflict && port != 5353)

it is assumed that the port variable is in host byte order but it isn't, thus the comparison must be port != htons(5353) for the intended purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@undroidwish