Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code clean-up #12

Closed
9 tasks done
NikoOinonen opened this issue Sep 27, 2022 · 3 comments
Closed
9 tasks done

Code clean-up #12

NikoOinonen opened this issue Sep 27, 2022 · 3 comments
Assignees

Comments

@NikoOinonen
Copy link
Collaborator

NikoOinonen commented Sep 27, 2022

There seems to be a lot of unused code and old/alternative versions of functions and modules that could probably be deleted. Additionally, some things could be renamed and reorganized to be cleaner. I'm afraid to just go and delete things, so I'll list here the things that I would change, and we can discuss it.

@NikoOinonen
Copy link
Collaborator Author

I also tried running flake8 to detect problems in the code. The report is in the attachment. There seems to be many cases (113) of undefined variables and a couple of syntax errors. These lines of code will never run, so I guess they have never been tested or are remainders from earlier versions. Maybe @ProkopHapala could look through these to see if they should be fixed or just deleted.

flake8_test.txt

@ProkopHapala
Copy link
Collaborator

flake8_test.txt
Thank you Niko, I did not know about such tool

@NikoOinonen
Copy link
Collaborator Author

All of the listed issues have been resolved, so closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants