Infrastructure: Duplicated ACPI Tables, impacting updates for ref platforms

[gus33000]

Select QTI platforms have their ACPI files fully provided by the ACPI binary repository, due to this repo build system it is required to duplicate these files currently into the device ACPI folder with no possibility to override such requirement to instead use the file naturally available under SurfaceDuoACPI\QcomACPI\8350\builtin\DSDT_8350_MTP.aml for example.

It would be great if this could get improved for easy updates, currently we have to manually copy over each file one by one and even rename them to address this.

Further more; select devices may need to override more tables in the future, like for the debug table due to different GENI UART QUP usage for debugging (See OEM Corporation OEMZE device for a prime example of such thing)

[sunflower2333]

If there is a way to override it ...

[sunflower2333]

How about make a symbol link to the reference devices' acpi in reference devices' ACPI/DSDT.aml

[gus33000]

I was thinking at some point given the links keep increasing, that maybe we should adopt the normal edkII/mu model to have multiple platforms here. I would be up for one package for one device. This would also resolve a few issues where a device may not have a memory map compatible enough to afford reusing the existing defacto base address in the fdf. That was a bit of the spirit in SurfaceDuo1Pkg and 2Pkg, it also contains very minimal lines in the end and you would be able to dial in the dxes you want with ease, and the acpi tables

[sunflower2333]

well that make sense. But it will take time to refactor the whole repo and will reduced reusability, slow down ci, increase porting difficulty etc.
However as you say it can solve some issues currently meeting.
So i hope to find compromise solution that ensure reusability while meeting standards.

[gus33000]

Build times shouldn't be an issue anymore ever since we modified the ci to build every target in parallel and not consecutively. Of course this will increase aggregated custom workflows, like the one building only ref platforms or everything 855 but those iirc are also parallelized? Or should be made to be parallel

[sunflower2333]

OK i will try refactor next year. Do you have any ideas about folder structure?

Is Platforms/<PlatformName>/<VendorName>/<DeviceCodeName> okay?

For example:
Platforms/Lahaina/QTI/MTP888Pkg