Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestNetworkConsistency error when modify a network #9

Open
yiheng-wang-nv opened this issue Nov 5, 2021 · 2 comments
Open

TestNetworkConsistency error when modify a network #9

yiheng-wang-nv opened this issue Nov 5, 2021 · 2 comments

Comments

@yiheng-wang-nv
Copy link
Contributor

Hi, I made a PR to modify DynUNet: Project-MONAI/MONAI#3265
However, due to the fixed network weights here, an error will be raised in TestNetworkConsistency
See:
https://github.com/Project-MONAI/MONAI/runs/4115820050?check_suite_focus=true

I'm wondering what should be the right order for network modification? Thanks!

@wyli
Copy link
Contributor

wyli commented Nov 5, 2021

Hi Yiheng, for this particular PR, is it possible to make it non-breaking? otherwise please submit a PR to this repo first.

@wyli
Copy link
Contributor

wyli commented Nov 8, 2021

Hi Yiheng, I undo #10 because of the testing error https://github.com/Project-MONAI/MONAI/runs/4143645515?check_suite_focus=true

could we make sure the previously saved weights can still work with Project-MONAI/MONAI#3265?

I put your previous commit here https://github.com/Project-MONAI/MONAI-extra-test-data/tree/backup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants