Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance DatasetSummary for several points #3559

Closed
Nic-Ma opened this issue Dec 31, 2021 · 0 comments · Fixed by #3560
Closed

Enhance DatasetSummary for several points #3559

Nic-Ma opened this issue Dec 31, 2021 · 0 comments · Fixed by #3560
Assignees
Labels
enhancement New feature or request

Comments

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Dec 31, 2021

Is your feature request related to a problem? Please describe.
Thanks for @dongyang0122 's great work to develop DatasetSummary, would be nice to enhance the below items:

  1. It only has meta_key_postfix arg, missed meta_key to be consistent with other MONAI modules when using flexible meta key: https://github.com/Project-MONAI/MONAI/blob/dev/monai/transforms/io/dictionary.py#L68
  2. The spacing data or image, label may not be Tensor, it depends on the Dataset and collate_fn of DataLoader, need to convert data type to Tensor first.
  3. It supports kwargs for DataLoader but didn't cover it in the unit tests, would be nice to add it.
@Nic-Ma Nic-Ma added the enhancement New feature or request label Dec 31, 2021
@Nic-Ma Nic-Ma added this to the Bug Fixes or Misc improvements milestone Dec 31, 2021
@Nic-Ma Nic-Ma self-assigned this Dec 31, 2021
@Nic-Ma Nic-Ma added this to MONAI 0.9 Dec 31, 2021
@Nic-Ma Nic-Ma moved this to Done in MONAI 0.9 Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant