Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONAI Pathology Overall Structure #4005

Closed
drbeh opened this issue Mar 25, 2022 · 5 comments
Closed

MONAI Pathology Overall Structure #4005

drbeh opened this issue Mar 25, 2022 · 5 comments
Assignees
Labels
Design discussions related to the generic API designs

Comments

@drbeh
Copy link
Member

drbeh commented Mar 25, 2022

Here I have prepared the overall structure of MONAI Pathology when blending into the core MONAI. Please feel free to put you comments and I will update it accordingly.

Overall Structure

I will create separate issues for each of the components that requires changes or needs to be implemented. We will address these changes in a new branch for pathology and will merge when ready.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Mar 30, 2022

Hi @drbeh ,

Thanks for your detailed summary, looks good.
Looking forward to the following PRs that refactor them into the core code.

Thanks.

@drbeh drbeh moved this from In Progress to Under Review in AI in Pathology🔬 Apr 8, 2022
@drbeh drbeh moved this from Under Review to Done in AI in Pathology🔬 Apr 11, 2022
@drbeh drbeh closed this as completed Apr 20, 2022
@JohnMasoner
Copy link
Contributor

Hi @drbeh ,

I'm sorry that i comment the closed the issus.
I‘m watching #4006, the issus brought this to my attention.
I want to know what's app to plot the Overall Structure Picture.

Thanks.

@drbeh
Copy link
Member Author

drbeh commented Jul 5, 2022

Hi @JohnMasoner,
I have used Miro for those diagrams: https://miro.com
Regarding #4006, can you let me know what is your use case?
Thanks

@JohnMasoner
Copy link
Contributor

Hi @drbeh ,
Actually, I want to trying to contribution the #4006.
I am learning something about #4006 ,maybe i can do it.
Thanks

@drbeh
Copy link
Member Author

drbeh commented Jul 7, 2022

Hi @JohnMasoner,

Absolutely, that's the whole point of an open-source library. #4006 requires some architecting and defining how the component should interface with each other but would be great if you can make any contribution. Please discuss your design on #4006 or start a draft pull request as soon as you have something to discuss (don't wait until all the done).

We also have implemented this stain normalizer in cucim, so feel free to take a look at it too.
https://github.com/rapidsai/cucim/blob/branch-22.08/python/cucim/src/cucim/core/operations/color/stain_normalizer.py

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design discussions related to the generic API designs
Projects
Status: 💯 Complete
Development

No branches or pull requests

3 participants