Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore warning from nptyping as workaround #8062

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Sep 2, 2024

workaround for #8060

Description

Ignore warning from nptyping as workaround

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 2, 2024

We didn't update the version of nptyping, which is a dependency for pynrrd, yet the error suddenly started occurring. As a workaround, I suppress the warning.
https://github.com/ramonhagenaars/nptyping/blob/785cd07e65f992f47256398fd01f62067928d29c/nptyping/typing_.py#L51

Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
monai/data/image_reader.py Outdated Show resolved Hide resolved
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: YunLiu <55491388+KumoLiu@users.noreply.github.com>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Sep 2, 2024

/build

@ericspod
Copy link
Member

ericspod commented Sep 2, 2024

I'm not seeing from the mentioned issue what the nptyping problem is, I guess this fix is fine so long as nothing else is hidden. I would just check that it's not related to Numpy2 or something else being updated elsewhere.

@KumoLiu KumoLiu merged commit dbfe418 into Project-MONAI:dev Sep 2, 2024
28 checks passed
@KumoLiu KumoLiu deleted the nptyping branch September 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants