Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for rotate_range indicates the wrong sign #8340

Open
maxime915 opened this issue Feb 14, 2025 · 0 comments
Open

Doc for rotate_range indicates the wrong sign #8340

maxime915 opened this issue Feb 14, 2025 · 0 comments

Comments

@maxime915
Copy link

Hello,

I think there is an extra minus sign in the doc for the first value of the rotate_range parameter.

`uniform[-rotate_range[i][0], rotate_range[i][1])` will be used to generate the rotation parameter

The method _get_rand_param uses the range without any minus sign added to the first argument.

out_param.append(self.R.uniform(f[0], f[1]) + add_scalar)

If you agree that this is just a documentation issue, I'd be happy to search for other transform having the same issue (RandAffine and RandAffined seem to have the same issue) and create a PR to remove the extra signs.

Best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant