Skip to content

Commit c566f1b

Browse files
authored
Merge pull request #108 from Project-MONAI/use_consistent_project_name
Use consistent project name - MONAI Deploy App SDK
2 parents e3b2b88 + 40cfff6 commit c566f1b

File tree

9 files changed

+25
-25
lines changed

9 files changed

+25
-25
lines changed

.github/ISSUE_TEMPLATE/bug_report.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: Bug report
3-
about: Create a bug report to help us improve MONAI Deploy Application SDK
3+
about: Create a bug report to help us improve MONAI Deploy App SDK
44
title: "[BUG] "
55
labels: bug
66
assignees: ''
@@ -26,7 +26,7 @@ A clear and concise description of what you expected to happen.
2626

2727
- OS/Platform:
2828
- Python Version:
29-
- Method of MONAI Deploy Application SDK install: [pip, conda, Docker, or from source]
29+
- Method of MONAI Deploy App SDK install: [pip, conda, Docker, or from source]
3030
- SDK Version:
3131

3232
**Additional context**

.github/ISSUE_TEMPLATE/feature_request.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
name: Feature request
3-
about: Suggest an idea for MONAI Deploy Application SDK
3+
about: Suggest an idea for MONAI Deploy App SDK
44
title: "[FEA] "
55
labels: enhancement
66
assignees: ''
@@ -9,7 +9,7 @@ assignees: ''
99

1010
**Is your feature request related to a problem? Please describe.**
1111
<!--
12-
A clear and concise description of what the problem is. Ex. I wish I could use MONAI Deploy Application SDK to do [...]
12+
A clear and concise description of what the problem is. Ex. I wish I could use MONAI Deploy App SDK to do [...]
1313
-->
1414

1515
**Describe the solution you'd like**

CONTRIBUTING.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,23 +17,23 @@
1717

1818
## Introduction
1919

20-
Welcome to Project MONAI Deploy Application SDK (MONAI App SDK)! We're excited you're here and want to contribute. This documentation is intended for individuals and institutions interested in contributing to MONAI App SDK. MONAI App SDK is an open-source project and, as such, its success relies on its community of contributors willing to keep improving it. Your contribution will be a valued addition to the code base; we simply ask that you read this page and understand our contribution process, whether you are a seasoned open-source contributor or whether you are a first-time contributor.
20+
Welcome to Project MONAI Deploy App SDK! We're excited you're here and want to contribute. This documentation is intended for individuals and institutions interested in contributing to MONAI Deploy App SDK. MONAI Deploy App SDK is an open-source project and, as such, its success relies on its community of contributors willing to keep improving it. Your contribution will be a valued addition to the code base; we simply ask that you read this page and understand our contribution process, whether you are a seasoned open-source contributor or whether you are a first-time contributor.
2121

2222
### Communicate with us
2323

24-
We are happy to talk with you about your needs for MONAI App SDK and your ideas for contributing to the project. One way to do this is to create an issue discussing your thoughts. It might be that a very similar feature is under development or already exists, so an issue is a great starting point. If you are looking for an issue to resolve that will help Project MONAI App SDK, see the [*good first issue*](https://github.com/Project-MONAI/monai-deploy-app-sdk/labels/good%20first%20issue) and [*Contribution wanted*](https://github.com/Project-MONAI/monai-deploy-app-sdk/labels/Contribution%20wanted) labels.
24+
We are happy to talk with you about your needs for MONAI Deploy App SDK and your ideas for contributing to the project. One way to do this is to create an issue discussing your thoughts. It might be that a very similar feature is under development or already exists, so an issue is a great starting point. If you are looking for an issue to resolve that will help Project MONAI Deploy App SDK, see the [*good first issue*](https://github.com/Project-MONAI/monai-deploy-app-sdk/labels/good%20first%20issue) and [*Contribution wanted*](https://github.com/Project-MONAI/monai-deploy-app-sdk/labels/Contribution%20wanted) labels.
2525

2626
## The contribution process
2727

2828
_Pull request early_
2929

3030
We encourage you to create pull requests early. It helps us track the contributions under development, whether they are ready to be merged or not. Change your pull request's title, to begin with `[WIP]` and/or [create a draft pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests#draft-pull-requests) until it is ready for formal review.
3131

32-
Please note that, as per PyTorch, MONAI App SDK uses American English spelling. This means classes and variables should be: normali**z**e, visuali**z**e, colo~~u~~r, etc.
32+
Please note that, as per PyTorch, MONAI Deploy App SDK uses American English spelling. This means classes and variables should be: normali**z**e, visuali**z**e, colo~~u~~r, etc.
3333

3434
### Preparing pull requests
3535

36-
To ensure the code quality, MONAI App SDK relies on several linting tools ([flake8 and its plugins](https://gitlab.com/pycqa/flake8), [black](https://github.com/psf/black), [isort](https://github.com/timothycrosley/isort)),
36+
To ensure the code quality, MONAI Deploy App SDK relies on several linting tools ([flake8 and its plugins](https://gitlab.com/pycqa/flake8), [black](https://github.com/psf/black), [isort](https://github.com/timothycrosley/isort)),
3737
static type analysis tools ([mypy](https://github.com/python/mypy), [pytype](https://github.com/google/pytype)), as well as a set of unit/integration/system tests.
3838

3939
This section highlights all the necessary preparation steps required before sending a pull request.
@@ -87,7 +87,7 @@ If you intend for any variables/functions/classes to be available outside of the
8787

8888
#### Unit testing
8989

90-
MONAI App SDK tests are located under `tests/` (it has `unit`/`integration`/`performance`/`system` subfolders.)
90+
MONAI Deploy App SDK tests are located under `tests/` (it has `unit`/`integration`/`performance`/`system` subfolders.)
9191

9292
- The unit test's file name currently follows `test_[module_name].py` or `test_[module_name]_dist.py`.
9393
- The `test_[module_name]_dist.py` subset of unit tests requires a distributed environment to verify the module with distributed GPU-based computation.
@@ -120,10 +120,10 @@ or (for new features that would not break existing functionality):
120120
_If it's not tested, it's broken_
121121

122122
All new functionality should be accompanied by an appropriate set of tests.
123-
MONAI App SDK functionality has plenty of unit tests from which you can draw inspiration,
123+
MONAI Deploy App SDK functionality has plenty of unit tests from which you can draw inspiration,
124124
and you can reach out to us if you are unsure of how to proceed with testing.
125125

126-
MONAI APP SDK's code coverage report is available at [CodeCov](https://codecov.io/gh/Project-MONAI/monai-deploy-app-sdk).
126+
MONAI Deploy App SDK's code coverage report is available at [CodeCov](https://codecov.io/gh/Project-MONAI/monai-deploy-app-sdk).
127127

128128
#### Building the documentation
129129

@@ -152,7 +152,7 @@ Before submitting a pull request, it is recommended to:
152152
- [MyST with Sphinx](https://myst-parser.readthedocs.io/en/v0.15.2_a/sphinx/index.html)
153153
- check the auto-generated documentation (by browsing the generated documents after executing `./run gen_docs_dev`)
154154
- build HTML documentation locally (`./run gen_docs`)
155-
- execute `./run gen_docs_dev` to clean temporary and final documents.
155+
- execute `./run clean_docs` to clean temporary and final documents.
156156

157157
#### Automatic code formatting
158158

README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
<img src="https://raw.githubusercontent.com/Project-MONAI/MONAI/dev/docs/images/MONAI-logo-color.png" width="50%" alt='project-monai'>
33
</p>
44

5-
# MONAI Deploy Application SDK
5+
# MONAI Deploy App SDK
66

7-
MONAI Deploy Application SDK offers a framework and associated tools to design, verify and analyze the performance of AI-driven applications in the healthcare domain.
7+
MONAI Deploy App SDK offers a framework and associated tools to design, verify and analyze the performance of AI-driven applications in the healthcare domain.
88

99
## Features
1010

@@ -64,7 +64,7 @@ For local development, please execute the following command:
6464

6565
This will set up the development environment, installing necessary packages.
6666

67-
For guidance on making a contribution to MONAI Deploy Application SDK, see the [contributing guidelines](CONTRIBUTING.md).
67+
For guidance on making a contribution to MONAI Deploy App SDK, see the [contributing guidelines](https://github.com/Project-MONAI/monai-deploy-app-sdk/blob/main/CONTRIBUTING.md).
6868

6969
## Community
7070

docs/source/conf.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121

2222
# -- Project information -----------------------------------------------------
23-
project = "MONAI Deploy Application SDK"
23+
project = "MONAI Deploy App SDK"
2424
copyright = "2021 MONAI Consortium"
2525
author = "MONAI Contributors"
2626

docs/srs.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# MONAI Deploy Application SDK
1+
# MONAI Deploy App SDK
22

33
## Introduction
44

@@ -29,7 +29,7 @@ For each requirement, the following attributes have been specified:
2929
* **Requirement Body**: This is the text of the requirement which describes the goal and purpose behind the requirement
3030
* **Background**: Provides necessary background to understand the context of the requirements
3131
* **Verification Strategy**: A high-level plan on how to test this requirement at a system level
32-
* **Target Release**: Specifies which release of the MONAI App SDK this requirement is targeted for
32+
* **Target Release**: Specifies which release of the MONAI Deploy App SDK this requirement is targeted for
3333

3434
---
3535

@@ -93,7 +93,7 @@ The SDK shall enable dependencies among upstream and downstream operators in an
9393

9494
### Background
9595

96-
Most healthcare application workflows involve multiple stages. Application developers need a way to organize functional units of AI-based inference apps. A DAG (Directed Acyclic Graph) is the core concept of MONAI App SDK, collecting Operators together, organized with dependencies and relationships to specify how they should run.
96+
Most healthcare application workflows involve multiple stages. Application developers need a way to organize functional units of AI-based inference apps. A DAG (Directed Acyclic Graph) is the core concept of MONAI Deploy App SDK, collecting Operators together, organized with dependencies and relationships to specify how they should run.
9797

9898
### Verification Strategy
9999

@@ -311,7 +311,7 @@ The SDK shall allow integration of a Clara Train generated Medical Model ARchive
311311

312312
### Background
313313

314-
MMAR defines the standard structure for storing artifacts (files) needed and produced by the model development workflow (training, validation, inference, etc.). The MMAR includes all the information about the model including configurations and scripts to provide a workspace to perform different model development tasks. In the context of the MONAI App SDK, the relevant usage of the MMAR is for the purpose of inference.
314+
MMAR defines the standard structure for storing artifacts (files) needed and produced by the model development workflow (training, validation, inference, etc.). The MMAR includes all the information about the model including configurations and scripts to provide a workspace to perform different model development tasks. In the context of the MONAI Deploy App SDK, the relevant usage of the MMAR is for the purpose of inference.
315315

316316
### Verification Strategy
317317

monai/deploy/operators/monai_seg_inference_operator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ def _get_meta_dict(self, img: Image) -> Dict:
267267
Get the meta data of the image and convert to dict type.
268268
269269
Args:
270-
img: an Monai App Sdk Image object.
270+
img: a MONAI Deploy App SDK Image object.
271271
"""
272272
img_meta_dict = img.metadata()
273273
meta_dict = {key: img_meta_dict[key] for key in img_meta_dict.keys()}

monai/deploy/utils/importutil.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def get_docstring(cls: Type) -> str:
4444

4545

4646
def is_subclass(cls: Type, class_or_tuple: Union[str, Tuple[str]]) -> bool:
47-
"""Check if the given type is a subclass of a MONAI App SDK class.
47+
"""Check if the given type is a subclass of a MONAI Deploy App SDK class.
4848
4949
Args:
5050
cls (Type): A class to check.

monai/deploy/utils/version.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
def get_sdk_semver():
6565
"""Convert a version string to a semver string.
6666
67-
MONAI App SDK is a python package and its version is based on PEP-0440
67+
MONAI Deploy App SDK is a python package and its version is based on PEP-0440
6868
(https://www.python.org/dev/peps/pep-0440/).
6969
7070
e.g., 0.1.0a1, 1.0.0a2.dev456, 1.0+abc.5, 0.1.0a1+0.g8444606.dirty
@@ -74,9 +74,9 @@ def get_sdk_semver():
7474
[N!]N(.N)*[{a|b|rc}N][.postN][.devN]
7575
7676
MONAI Application Package (MAP) requires a semver string to be used in.
77-
The semver string is used to identify the version of the MONAI App SDK package.
77+
The semver string is used to identify the version of the MONAI Deploy App SDK package.
7878
79-
This method converts the MONAI App SDK package version string to a semver string.
79+
This method converts the MONAI Deploy App SDK package version string to a semver string.
8080
8181
This uses a regular expression from the following link to parse the version string.
8282

0 commit comments

Comments
 (0)