Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need app running definition and requirements standardization capabilities and a common way to pass this onto platforms during deployment #226

Open
GreySeaWolf opened this issue Dec 11, 2021 · 3 comments
Labels
architectural story Work related to architecture

Comments

@GreySeaWolf
Copy link
Contributor

Developers should be able to specify the requirements for their algorithms. One should be able to specify the minimum memory, number of GPUs needed, as well as input and output requirements for their algorithm. For example, one can say my expected input is CT Chest with No Contrast with a maximum slice thickness of 3mm, the algorithm needs to be always on (a request may come any time). The expected image input is DICOM, the expected output is DICOM SR. I need 1 GPU, my memory needs are 1GB per GPU, etc.

@GreySeaWolf GreySeaWolf changed the title Need app running definition and requirements standardization capabilities and a common way to pass this onto Workflow Manager and MIIS during deployment Need app running definition and requirements standardization capabilities and a common way to pass this onto Workflow Manager and MIS during deployment Dec 11, 2021
@GreySeaWolf GreySeaWolf added the architectural story Work related to architecture label Dec 11, 2021
@MMelQin
Copy link
Collaborator

MMelQin commented Dec 14, 2021

System memory, GPU and GPU mem are already supported in the spec of the MAP manifest. Such attributes are specified as decorators on application, which is then parsed by an utility for the App Packager to encode in the manifest.

Some of the specific DICOM input attributes can be handled by the base Series Selector or the extension of it, though there is indeed a need to expose such info/metadata so that the workflow definition can programmatically consume it, as discussed on the overall Deploy issue board.

@dbericat
Copy link
Member

After MONAI Bundle inference.json available on 1.x, how many of the DICOM required operators do we still want to expose as metadata for platforms to read and act upon?

@GreySeaWolf @MMelQin @ericspod @vikashg @tomaroberts

@dbericat dbericat changed the title Need app running definition and requirements standardization capabilities and a common way to pass this onto Workflow Manager and MIS during deployment Need app running definition and requirements standardization capabilities and a common way to pass this onto platforms during deployment Nov 10, 2022
@MMelQin
Copy link
Collaborator

MMelQin commented Nov 10, 2022

After MONAI Bundle inference.json available on 1.x, how many of the DICOM required operators do we still want to expose as metadata for platforms to read and act upon?

@GreySeaWolf @MMelQin @ericspod @vikashg @tomaroberts

Sorry, the question seems to have confused different things together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architectural story Work related to architecture
Projects
None yet
Development

No branches or pull requests

3 participants