Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] #305

Closed
paynowski opened this issue Jun 29, 2022 · 2 comments
Closed

[DOC] #305

paynowski opened this issue Jun 29, 2022 · 2 comments
Assignees
Labels
Contribution wanted If you are looking for an issue to resolve that will help Project MONAI App SDK documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@paynowski
Copy link

Report incorrect documentation

Location of incorrect documentation
(https://docs.monai.io/projects/monai-deploy-app-sdk/en/stable/getting_started/tutorials/03_segmentation_app.html)

Describe the problems or issues found in the documentation
Missing several install steps.

Steps taken to verify documentation is incorrect
I had to add the following pip installations: scikit-image, numpy-stl and trimesh

Suggested fix for documentation
Add missing installation steps

Report needed documentation

Report needed documentation

Describe the documentation you'd like
Add the extra pip steps in the "Execute from Shell" section

Steps taken to search for needed documentation

@paynowski paynowski added the documentation Improvements or additions to documentation label Jun 29, 2022
@dbericat dbericat added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Contribution wanted If you are looking for an issue to resolve that will help Project MONAI App SDK labels Jun 29, 2022
@MMelQin
Copy link
Collaborator

MMelQin commented Jul 6, 2022

Thanks for reporting the issue, whose root cause is the missed doc update following the addition of the STL Mesh operator to the Spleen Seg example app. The same is also reported in #299.

@MMelQin MMelQin added this to the v0.4 milestone Jul 11, 2022
@gigony gigony mentioned this issue Jul 12, 2022
@MMelQin
Copy link
Collaborator

MMelQin commented Jul 13, 2022

Added a comment in the latest doc on these dependencies when an app uses the STL Conversion operator.

@MMelQin MMelQin closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution wanted If you are looking for an issue to resolve that will help Project MONAI App SDK documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants