Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip installs at start of each notebook? #50

Closed
rijobro opened this issue Oct 27, 2020 · 5 comments
Closed

Pip installs at start of each notebook? #50

rijobro opened this issue Oct 27, 2020 · 5 comments
Labels
question Further information is requested

Comments

@rijobro
Copy link
Contributor

rijobro commented Oct 27, 2020

Should we be pip installing monai and its dependencies at the start of each notebook?

Discussion continued from #47.

My personal feeling is that we should lift all pip installs from our notebooks as the relevant instructions are already in our README.md. It also saves us from having to update as our notebooks/dependencies change.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 5, 2020

Hi @wyli and @ericspod ,

Should we raise a discussion about this topic in next MONAI meeting?
Thanks.

@wyli
Copy link
Contributor

wyli commented Nov 5, 2020

we've discussed this in the meeting already, the solution is to tag a branch such as v0.3.0, which will depend on pip install monai==0.3.0. and the master branch depends on pip install git+https://github.com/Project-MONAI/MONAI#egg=MONAI.

we need some CI tests to ensure the master branch works fine

@wyli
Copy link
Contributor

wyli commented Nov 6, 2020

Just pushed 0.3.0 tag https://github.com/Project-MONAI/tutorials/tree/0.3.0,
so for the users with pip install monai==0.3.0, they should check out this link, instead of the tutorial's master branch.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Nov 10, 2020

Sounds good! Thanks @wyli

@Nic-Ma Nic-Ma added the question Further information is requested label Nov 10, 2020
@wyli
Copy link
Contributor

wyli commented Nov 27, 2020

this makes Colab not directly runnable. so we need some instructions for colab user to manually add a %pip install monai cell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants