Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractor.cpp: sums computed in parallel need to be properly reduced. #1289

Closed
DennisOSRM opened this issue Nov 24, 2014 · 2 comments
Closed

Comments

@DennisOSRM
Copy link
Collaborator

Thanks to @joto's hawk eyes we now know that stats are not properly done in parallel:

case osmium::item_type::node:
  ++number_of_nodes;
  luabind::call_function<void>(
    scripting_environment.getLuaState(),
    "node_function",
    boost::cref(static_cast<osmium::Node &>(*entity)),
      boost::ref(result_node));
    resulting_nodes.push_back(std::make_pair(x, result_node));
 break;

same holds true for number_of_ways and number_of_relations.

@TheMarex
Copy link
Member

Should be fixed by #1312 right?

@DennisOSRM
Copy link
Collaborator Author

Yes. Good catch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants