Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reevaluate usage of OSRM's std_hash #3962

Closed
karenzshea opened this issue Apr 20, 2017 · 3 comments
Closed

Reevaluate usage of OSRM's std_hash #3962

karenzshea opened this issue Apr 20, 2017 · 3 comments

Comments

@karenzshea
Copy link
Contributor

As we have in https://github.com/Project-OSRM/osrm-backend/blob/c81baae1b9ae09dabfe4c09e37d97f907b735be2/include/util/std_hash.hpp

Questions

  • Wherever it's used, can it be replaced with boost::hash ?
  • If not why

cc @daniel-j-h

@daniel-j-h
Copy link
Member

Can't tell why - even the golden ratio number for mixing is the same; make sure to cross-check against Boost 1.55, though. We still support this version for Trusty and boost-latest ppas.

http://www.boost.org/doc/libs/1_55_0/doc/html/hash/reference.html#boost.hash_combine

Good way to find out: rip it out then see what Travis has to say. We run on Trusty, so that should be fine.

@danpat
Copy link
Member

danpat commented Apr 20, 2017

@karenzshea I suspect at some point we had a std::unordered_map<std::pair<int,int>,blah> somewhere in our code - doesn't look like we do any more, so this is probably dead code.

Like @daniel-j-h said - try removing it and see if anything breaks :-)

@karenzshea
Copy link
Contributor Author

We should keep this implementation around - while we're still on 14.04 ubuntu/1.54 boost, boost hash does not magically work for everything, such as tuples, on certain compilers that we're supporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants