Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for conditional access tags #4231

Open
danpat opened this issue Jul 3, 2017 · 4 comments
Open

Support for conditional access tags #4231

danpat opened this issue Jul 3, 2017 · 4 comments

Comments

@danpat
Copy link
Member

danpat commented Jul 3, 2017

With #3841, we gained support for conditional turn restrictions.

We should also implement conditional access:conditional tags, example:

https://www.openstreetmap.org/way/242346384

@daniel-j-h
Copy link
Member

@karenzshea can you spec out the tasks that need to be done here?

@karenzshea
Copy link
Contributor

We can expand the meaning of our existing conditional restriction flags to include access=conditional tags on non-relation features.

  • During way parsing in extraction, save ways tagged with access:conditional to disk like we do with restrictions with data node ids, is_only and opening hours.
    • this will probably require a new osrm file, or we'll need to figure out how to make them share the .osrm.restrictions file
    • we can maybe genericize the serializer for both restricted turns and ways
  • In the update handler (shared by contraction/customization) parse way restrictions and apply them if the condition is valid
  • Tests

A lot of the hard work is already in place, like condition validation and time zone handling, so this shouldn't be as complicated of a lift as conditional turns.

@xuruiray
Copy link

Do we support conditional access now?

@joaommartins
Copy link

Do we support conditional access now?

Still not supported, tested today.

This feature is referenced by:
#4300
#5801
#6706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants