Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress edge if it crosses a traffic signal #5385

Closed
wangyoucao577 opened this issue Mar 1, 2019 · 1 comment
Closed

compress edge if it crosses a traffic signal #5385

wangyoucao577 opened this issue Mar 1, 2019 · 1 comment

Comments

@wangyoucao577
Copy link
Contributor

I saw below comments and codes at graph_compressor.cpp#L210:

    /*
    // Do not compress edge if it crosses a traffic signal.
    // This can't be done in CanCombineWith, becase we only store the
    // traffic signals in the `traffic signal` list, which EdgeData
    // doesn't have access to.
    */
    const bool has_node_penalty = traffic_signals.find(node_v) != traffic_signals.end();
    EdgeDuration node_duration_penalty = MAXIMAL_EDGE_DURATION;
    EdgeWeight node_weight_penalty = INVALID_EDGE_WEIGHT;
    if (has_node_penalty)
    {
        ...
    }

From above codes, I think the "compress edge if it crosses a traffic signal" has already been implemented. But the comments make me confused when I'm reading these codes.
After check the commit history, I found that the function has been merged by PR #4327 , only comments not up to date.

@wangyoucao577
Copy link
Contributor Author

I have created PR #5384 for correct the comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant