Remove redundant loading of .osrm.cell_metrics #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using process memory, MLD cell metrics are loaded twice from .osrm.cell_metrics - once when loading static data, and again when loading updatable data. The former appears to be the mistake, as .osrm.cell_metrics is only listed in `GetUpdatableFiles`.
|
Also loaded here: osrm-backend/src/storage/storage.cpp Line 571 in 50d9632 |
akashihi
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When using process memory, MLD cell metrics are loaded twice from
.osrm.cell_metrics- once when loading static data, and again when loading updatable data. The former appears to be the mistake, as.osrm.cell_metricsis only listed inGetUpdatableFiles.Impact
For
germany-latest.osm.pbf, saves between 100-200ms when loadingosrm-routedTasklist
Requirements / Relations