-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird driving directions / path generated in certain areas #6069
Comments
@mjjbell There is a |
@danpat this is a manifestation of an issue you pointed out in the original PR. The duplicated edges that make up restriction paths are not included in the R-tree, so they can't be waypoints. This is a problem here as the optimal path to the target is half-way through the u-turn restriction path, so it instead finds a path to the target that doesn't go through a duplicated edge. I don't know if there's a quick fix for this unfortunately. After applying the hefty #5953, support for duplicate restriction edges as waypoints is possible with a relatively small addition. |
In case anyone has some suggestions, this is what OSRM is seeing in reduced form.
This is a single via-way restriction, so this issue predates the multi-via PR, hence why I suspect there isn't an easy fix without supporting multiple waypoints at each input location. |
Is there any way to bypass the issue by modifying the OSM data? |
Only by removing the u-turn restriction, which isn't a good idea. If you are already building from source, you can apply #5953 and mjjbell@5c8e729 as a patch fix. |
@mjjbell , Thanks a lot for your reply. Just want to confirm. I need two fixes mjjbell/osrm-backend@3771e99 and mjjbell/osrm-backend@5c8e729, right? And also, these two are from another repository, is there any difference? Can I just replicate these two changes to Project-OSRM I checked out, or I have to use mjjbell/osrm-backend? Thanks again |
It's just my personal fork of this repo. If you add it as a remote to your |
I try to use OSRM to generate driving directions but it gives a weird result. I have checked the OSM data and I didn't see anything special there.
Can someone please help me find out whether this is an OSRM bug, or it is just a map issue that I can solve it by updating the OSM data.
I got the problem using version 5.25 built from source. But same problem can be directly reproduced on OSM website too. Here is an example:
I don't know why it does not just go straight and make a left turn at the end. The expected driving path can be generated using graphhopper though:
Thanks a lot in advance!
The text was updated successfully, but these errors were encountered: