Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cucumber Test give a strange result with viaroute #823

Closed
sonphnt opened this issue Dec 6, 2013 · 6 comments
Closed

Cucumber Test give a strange result with viaroute #823

sonphnt opened this issue Dec 6, 2013 · 6 comments

Comments

@sonphnt
Copy link

sonphnt commented Dec 6, 2013

We have a few issues related to viaroute wrong but they all have not been solved perfectly yet, so I try to make a cucumber test to find out the problem. And I found out 2 problems.
The first one we have some cases failed with viaroute. you can see the screenshot
1

The second one I only try to turn around node map 180 degrees to be easy to look at (go down from a to m instead of go up from a to m), I see cucumber test returns a different result compare to sceenshot1. It is very strange to me
2

Cucumber text code:
Test 1:
@routing @testbot @via @Oneway
Feature: Via points

Background:
    Given the profile "testbot"

Scenario: Multiple via points with oneways
    Given the node map
        |   | a |   |
        | c | b |   |
        | d |   |   |
        | e | f |   |
        |   | g | i |
        |   | h |   |
        |   | k | j |
        |   | l |   |
        |   | m |   |

    And the ways
        | nodes | oneway |
        | ab    |        |
        | fb    | yes    |
        | bcd   | yes    |
        | def   | yes    |
        | fg    |        |
        | gh    |        |
        | hk    |        |
        | gijk  |        |
        | klm   |        |

    When I route I should get
        | waypoints | route                   |
        | a,d,l,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,f,h,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,c,m     | ab,bcd,def,fg,gh,hk,klm |
        | a,d,h,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,e,h,m   | ab,bcd,def,fg,gh,hk,klm | 
        | a,m       | ab,bcd,def,fg,gh,hk,klm | 

Test 2
@routing @testbot @via @Oneway
Feature: Via points

Background:
    Given the profile "testbot"

Scenario: Multiple via points with oneways
    Given the node map
        |   | m |   |
        |   | l |   |
        | j | k |   |
        |   | h |   |
        | i | g |   |
        |   | f | e |
        |   |   | d |
        |   | b | c |
        |   | a |   |

    And the ways
        | nodes | oneway |
        | ab    |        |
        | fb    | yes    |
        | bcd   | yes    |
        | def   | yes    |
        | fg    |        |
        | gh    |        |
        | hk    |        |
        | gijk  |        |
        | klm   |        |

    When I route I should get
        | waypoints | route                   |
        | a,d,l,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,f,h,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,c,m     | ab,bcd,def,fg,gh,hk,klm |
        | a,d,h,m   | ab,bcd,def,fg,gh,hk,klm |
        | a,e,h,m   | ab,bcd,def,fg,gh,hk,klm | 
        | a,m       | ab,bcd,def,fg,gh,hk,klm | 

Thanks

@DennisOSRM
Copy link
Collaborator

Great! Can you make a pull request for these tests?

@sonphnt
Copy link
Author

sonphnt commented Dec 6, 2013

A pull request, what do you mean Dennis ? Can you tell me detail ?

@DennisOSRM
Copy link
Collaborator

@DennisOSRM
Copy link
Collaborator

@sonpnt Do you want to submit a pull request or shall I go ahead and add the tests?

@sonphnt
Copy link
Author

sonphnt commented Dec 9, 2013

Hi Dennis, I just made a pull request and waiting for your fixes to test again.

@DennisOSRM
Copy link
Collaborator

Thanks, much appreciated. Let's close here and move discussion to #827

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants