Skip to content

Pull in translations from Transifex #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1ec5 opened this issue Mar 14, 2017 · 2 comments
Closed

Pull in translations from Transifex #10

1ec5 opened this issue Mar 14, 2017 · 2 comments
Assignees

Comments

@1ec5
Copy link
Member

1ec5 commented Mar 14, 2017

This library should pull translations directly from Transifex and convert them into plist format to complement the existing English plist. This should be done as a build step to keep developers from having to access the Transifex API every time they run carthage bootstrap.

/cc @frederoni @freenerd

@1ec5 1ec5 self-assigned this Mar 14, 2017
@freenerd
Copy link
Member

Given that we would not walk lock-step with osrm-text-instructions anymore, this would break the integration tests (which are built by the javascript osrm-text-instructions).

@1ec5
Copy link
Member Author

1ec5 commented Mar 15, 2017

Another option is to pull in osrm-text-instructions as a submodule, but we’ll want to make sure that affects only our development process and doesn’t have any impact post-build (like when a developer integrates the framework). Either way, we’ll need to coordinate PRs that update translations between both repositories. (I’d like to avoid maintaining a separate suite of integration tests here if possible.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants