Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German: rename ramps to Auffahrt/Ausfahrt #118

Closed
freenerd opened this issue Jul 5, 2017 · 4 comments
Closed

German: rename ramps to Auffahrt/Ausfahrt #118

freenerd opened this issue Jul 5, 2017 · 4 comments

Comments

@freenerd
Copy link
Member

freenerd commented Jul 5, 2017

Breaking out from https://github.com/Project-OSRM/osrm-text-instructions/pull/116/files/da902d902e59137a819c349758698f90f03fa3ff#r125589780

We might want to rename Rampe to Auffahrt and Ausfahrt. Only thing I wonder about is if on_ramp and off_ramp will always only be used in that context, or are there other cases? motorway_link seems to be correctly identified as off_ramp, so we are fine there. Any other cases?

/cc @daniel-j-h @MoKob

@MoKob
Copy link

MoKob commented Jul 5, 2017

@freenerd I think we could consider using ramp types on trunks as well (not sure if we already do). Either way we should be able to always identify off/on correctly based on the origin type of the turn (e.g. non-motorway to motorway_link is always an on-ramp, motorway -> motorway_link an off ramp)

@freenerd
Copy link
Member Author

freenerd commented Jul 5, 2017

@MoKob can you open an osrm-backend ticket for that?

@MoKob
Copy link

MoKob commented Jul 5, 2017

@freenerd
Copy link
Member Author

freenerd commented Jul 6, 2017

Fixed in #122

@freenerd freenerd closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants