Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ref from name when not a motorway #133

Closed
willwhite opened this issue Jul 26, 2017 · 5 comments
Closed

Remove ref from name when not a motorway #133

willwhite opened this issue Jul 26, 2017 · 5 comments
Assignees

Comments

@willwhite
Copy link
Contributor

With this line we are still announcing the ref as part of the name in the case of a non-motorway. This is too verbose. Can we remove?

/cc @1ec5 @bsudekum

@1ec5
Copy link
Member

1ec5 commented Jul 27, 2017

It’s important to include the route number for a non-motorway when it’s available. Many U.S. routes and state routes are non-motorways, but as the user approaches the route, they may see at least one advance route turn assembly long before they see the blade sign indicating the street name. We have no way of knowing whether a road is more identifiable by its route number or its name at a particular intersection; OpenStreetMap doesn’t make that distinction.

In the following example, the route numbers are prominently posted, while the street name is difficult to spot:

advance

blade

But if you approach the same street at an unsignalized intersection, the street name may be the only thing signposted, so we shouldn’t get rid of the name either:

pike

@willwhite
Copy link
Contributor Author

It’s important to include the route number for a non-motorway when it’s available.

Other routing providers are announcing one or the other - not both - including in the situation you reference above.

Keep in mind that OSRM will continue to include route number data where available, so that it can be incorporated into turn banners. This is just about what is actually announced to the driver.

We have no way of knowing whether a road is more identifiable by its route number or its name at a particular intersection; OpenStreetMap doesn’t make that distinction.

How do we determine this information? Do we need a mapping effort around this?

@1ec5
Copy link
Member

1ec5 commented Jul 29, 2017

Agreed that it would be nice to announce only one, but the error rate would be too high as things stand. (Other routing providers aren't nearly perfect this regard either – it's a hard problem because signage isn't consistent.)

We have no way of knowing whether a road is more identifiable by its route number or its name at a particular intersection; OpenStreetMap doesn’t make that distinction.

How do we determine this information? Do we need a mapping effort around this?

Among established tagging conventions in OSM, the closest thing I can think of is destination sign relations, which are primarily meant for "follow the route" instructions (Project-OSRM/osrm-backend#3542).

Any tagging scheme to distinguish between names useful and useless for wayfinding would have to rely on relations, because the data would differ from one intersection to the next and from one direction to another. But I suppose that would require Project-OSRM/osrm-backend#482.

@1ec5
Copy link
Member

1ec5 commented Aug 2, 2017

Somewhat relatedly, I've noticed cases in which Google Maps announces both the destination (street name) and ref for an off ramp instruction, then omits the ref when repeating the instruction at the maneuver point. For example, in this route, Google Maps says something like "take the exit to FM 157, Industrial Boulevard", followed by "take the Industrial Boulevard exit". (SH 183 is a freeway but doesn't use exit numbers.)

I figure this is because "eff em one-fifty-seven" would make the instruction too verbose; at the same time, it is necessary to say at some point for wayfinding purposes. mapbox/mapbox-navigation-ios#331 would accomplish a similar effect on the client side, potentially requiring changes to this library.

@1ec5
Copy link
Member

1ec5 commented Dec 21, 2017

The decision whether to identify a surface street by its route number requires additional context that is out of scope for OSRM Text Instructions at this time, given that this library needs to maintain compatibility with plain-vanilla OSRM instances. However, a more specialized client library might be better positioned to account for factors such as municipal boundaries.

@1ec5 1ec5 closed this as completed Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants